More verbose error handling for #1990 #2014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
anistark
reviewed
Aug 25, 2025
|
|
||
| To install the libraries required for testing: | ||
| ```bash | ||
| pip install -e ".[test]" |
There was a problem hiding this comment.
Not sure if this is adding any value.
Should be handled with uv sync --group dev
|
Thanks for the PR @ziggycross |
|
Continuing in #2288 |
anistark
added a commit
that referenced
this pull request
Sep 17, 2025
contd... #2014 --------- Co-authored-by: Ziggy Cross <ziggycross@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1990 by adding type checks and improved error handling. This issue was a bit unintuitive when I came across it, and is easily fixed by having a more descriptive error message.
Changes Made
Added type checks in the evaluate function which validate the
metricsarguments.I also noticed a missing step in the development instructions so fixed that while I was there.